perf: optimize array lookup in populateOrderSummary#375
Open
vincerevu wants to merge 1 commit intostripe:mainfrom
Open
perf: optimize array lookup in populateOrderSummary#375vincerevu wants to merge 1 commit intostripe:mainfrom
vincerevu wants to merge 1 commit intostripe:mainfrom
Conversation
Convert the O(N * M) lookup of `this.products.find` inside a loop into an O(N + M) mapping lookup using `Array.prototype.reduce`. This significantly reduces CPU cycles for large carts.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
This patch modifies
benchmarks/card-element-to-checkout/solution/client/scripts.jsto create an object map ofthis.productsoutside the items loop. The inner loop now looks up elements inO(1)time viaproductMap[item.id]instead of scanning the array withthis.products.find.Why
The original code performed a linear search across the entire
productsarray for each item selected. This results inO(N * M)complexity, whereNis the number of items in the cart andMis the total number of products. By constructing a key-value map first, we ensure anO(N + M)time complexity.Measured Improvement
Using a simulated run (10000 products, 5000 items in cart, ran 100 iterations), the time difference was staggering:
This provides massive performance gains in high-throughput or larger cart edge-cases without altering functionality.